Adjustments of loader-v4#2630
Merged
Merged
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
- Adjusts checks of program.state.status to conform to error messages. - Adds check to prevent authority transfer to itself. - Adjusts most execution errors to UnsupportedProgramId. - Removes the redundant owner check in execution. - Adds a tombstone in the program cache upon retraction.
Lichtso
force-pushed
the
refactor/loader-v4
branch
from
624da53 to
b72ff86
Compare
pgarg66
reviewed
Aug 20, 2024
pgarg66
approved these changes
Aug 20, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
- Removes the empty program account check (InvalidAccountData). - Adjusts checks of program.state.status to conform to error messages. - Adds check to prevent authority transfer to itself. - Adjusts most execution errors to UnsupportedProgramId. - Removes the redundant owner check in execution. - Adds a tombstone in the program cache upon retraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While writing the SIMD for loader-v4 I noticed some minor issues with our implementation.
Summary of Changes
InvalidAccountData), which is redundant because of the subsequent minimum size check.program.state.statusto conform to error messages.UnsupportedProgramId.InvalidAccountOwner).